Disable --legacy_external_runfiles in Bazel tests
#20680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
flip-legacy-external-runfiles
branch
7 times, most recently
from
d5e9156
to
733f4c9
Compare
fmeum
changed the title
--legacy_external_runfiles--legacy_external_runfiles in Bazel tests
fmeum
force-pushed
the
flip-legacy-external-runfiles
branch
from
733f4c9
to
bb7fd4f
Compare
github-actions
bot
added
team-Configurability
sgowroji
added
awaiting-user-response
fmeum
force-pushed
the
flip-legacy-external-runfiles
branch
from
bb7fd4f
to
ec2ebba
Compare
|
I support this pending an answer to #12821 (comment) . |
fmeum
force-pushed
the
flip-legacy-external-runfiles
branch
from
ec2ebba
to
2119cf2
Compare
Prepares for the flip (bazelbuild#12821) by ensuring that Bazel itself doesn't regress.
fmeum
force-pushed
the
flip-legacy-external-runfiles
branch
from
2119cf2
to
666e2a5
Compare
|
@lberki A rebase fixed all test failures. Given that we can't go back to just the |
|
I support the idea. @Wyverald WDYT? (I don't want to just reach over his head) |
Wyverald
approved these changes
Jan 26, 2024
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 7.1.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 26, 2024
This requires fixing an actual bug that causes the Windows Java launcher to not find the Java runtime with `--nolegacy_external_runfiles`. Work towards bazelbuild#12821 Closes bazelbuild#20680. PiperOrigin-RevId: 601826685 Change-Id: Ib45e60901d47efc06bf875c334edafcaeabc5f1e
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2024
This requires fixing an actual bug that causes the Windows Java launcher to not find the Java runtime with `--nolegacy_external_runfiles`. Work towards #12821 Closes #20680. Commit 3d4491c PiperOrigin-RevId: 601826685 Change-Id: Ib45e60901d47efc06bf875c334edafcaeabc5f1e Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires fixing an actual bug that causes the Windows Java launcher to not find the Java runtime with
--nolegacy_external_runfiles.Work towards #12821